quiche: remove google quic support#17465
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
|
Unfortunately this lowers Envoy coverage below the acceptable limit. Maybe could land with beefing up some of the QUIC unit tests (as QUIC coverage was already pretty low) |
Signed-off-by: Dan Zhang <danzh@google.com>
|
Ahh, the joys of CI :-P |
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
So much cleanup!
I'd love if @wu-bin or @RenjieTang would do a QUIC pass, and I'll do another maintainer pass once CI is happy.
/wait
| ~EnvoyQuicProofVerifierBase() override = default; | ||
|
|
||
| // quic::ProofVerifier | ||
| // Return success if the certs chain is valid and signature of { |
There was a problem hiding this comment.
why is the comment removed? can it no longer return failure?
There was a problem hiding this comment.
VerifyProof() is NOT_REACHED_GCOVR_EXCL_LINE now. So the comment is out dated.
| @@ -117,22 +93,6 @@ void EnvoyQuicClientSession::OnTlsHandshakeComplete() { | |||
| raiseConnectionEvent(Network::ConnectionEvent::Connected); | |||
There was a problem hiding this comment.
Here I noticed that we are not calling the base class method.
It's not a big issue since the base class method does actual work only on servers. But I think it'd nice to still have those QUIC_BUGs.
| return; | ||
| } | ||
| switch (version.transport_version) { | ||
| case quic::QUIC_VERSION_43: |
There was a problem hiding this comment.
Since these counters are no longer used. I think they can be removed from docs/root/configuration/http/http_conn_man/stats.rst and source/common/http/http3/codec_stats.h
Signed-off-by: Dan Zhang <danzh@google.com>
RenjieTang
left a comment
RenjieTang
left a comment
There was a problem hiding this comment.
LGTM. I'm not an expert on QUIC proof source. Bin might know better there.
Signed-off-by: Dan Zhang <danzh@google.com>
|
coverage failures are likely real. PTAL? |
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
…bridge-stream * upstream/main: (140 commits) quiche: remove google quic support (envoyproxy#17465) runtime: removing envoy.reloadable_features.check_ocsp_policy (envoyproxy#17524) upstream: not trying to do HTTP/3 where not configured (envoyproxy#17454) api: Remove confusing line about auto-generation (envoyproxy#17536) v2: removing bootstrap (envoyproxy#17523) connpool: Fix crash in pool removal if the cluster was already deleted (envoyproxy#17522) Enhance the comments clearly (envoyproxy#17517) mysql proxy: connection attributes parsing (envoyproxy#17209) [ci] fix false positive CVE scan from node (envoyproxy#17510) Fixing Envoy Mobile factory strings (envoyproxy#17509) http3: validating codec (envoyproxy#17452) quic: add QUIC upstream stream reset error stats (envoyproxy#17496) thrift proxy: move UpstreamRequest into its own file (envoyproxy#17498) docs: Fixed FaultDelay docs. (envoyproxy#17495) updates links to jaegertracing-plugin.tar.gz (envoyproxy#17497) http: make custom inline headers bootstrap configurable (envoyproxy#17330) deps: update yaml-cpp to latest master (envoyproxy#17489) improving tracer coverage (envoyproxy#17493) Increase buffer size of `Win32RedirectRecords` (envoyproxy#17471) ext_proc: Fix problem with buffered body mode with empty or no body (envoyproxy#17430) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
Commit Message: Remove support of Google QUIC. QUICHE supports both IETF QUIC and Google QUIC. Given that IETF QUIC has been launched by Google and Google QUIC will be deprecated soon, remove the support of Google QUIC will lower the future maintenance burden. Risk Level: low Testing: existing tests passed Fixes envoyproxy#16642 Signed-off-by: Dan Zhang <danzh@google.com>
4 participants
Signed-off-by: Dan Zhang danzh@google.com
Commit Message: Remove support of Google QUIC. QUICHE supports both IETF QUIC and Google QUIC. Given that IETF QUIC has been launched by Google and Google QUIC will be deprecated soon, remove the support of Google QUIC will lower the future maintenance burden.
Risk Level: low
Testing: existing tests passed
Fixes #16642